6781 my data render #6802
Merged
6781 my data render #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
requested changes
Apr 9, 2020
| dv = ds.getReleasedVersion(); | ||
| DatasetVersion dv = null; | ||
|
|
||
| for (DatasetVersion v : ds.getVersions()) { |
There was a problem hiding this comment.
This is good, but let's move this logic onto a method on Dataset (in case we need to use it elsewhere some time, and then it makes this fewer lines, ie.
DatasetVersion dv = ds.getVersion(this.datasetVersionId);
There was a problem hiding this comment.
added the suggested method to Dataset
scolapasta
approved these changes
Apr 9, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Apr 9, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes MyData rendering
Which issue(s) this PR closes:
Closes #6781
Special notes for your reviewer:
Gets dataset version based on the versionId saved in the SolrSearchResult
Suggestions on how to test this:
Cannot be a super user. Also try oddball cases like only a draft and/or all versions deaccessioned.
Does this PR introduce a user interface change?:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None